fix: move openedx-auth patch to bottom of file to allow patching EMAIL and DATABASES settings #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L and DATABASES settings
DawoudSheraz
approved these changes
Jan 31, 2025
Danyal-Faheem
deleted the
danyal/support-other-databases-through-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openedx-authpatch is placed in an inconvenient position where adding DATABASES, XQUEUE or EMAIL settings to the patch does not actually apply these settings as they are below the patch so they are always overriden by the settings defined in Tutor.We move the patch to the bottom of the file so that these settings can be overriden by the patch.